Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to improve some rendering of aacar and kblads and add new properties for features without laterality. #36

Merged
merged 5 commits into from
Feb 19, 2025

Conversation

napakalas
Copy link
Contributor

This PR:

  • Update the alias from "urinary bladder" to "fundus of urinary bladder" to prevent a loopback issue in some kblad renderings.
  • Remove "contained-in" from T1 to T2 of ventral_root_ramus since it causes incorrect rendering of "aacar-6". This removal does not appear to affect other path renderings.
  • Handle "no lateral" features by adding the "noLaterality" property to the designated features.

@nickerso
Copy link

@napakalas - the the noLaterality property to address AnatomicMaps/flatmap-maker#114 ? if so, I think a better approach as we discussed is a property to states a given feature should not be used for routing connectivity knowledge.

@dbrnz
Copy link
Contributor

dbrnz commented Feb 12, 2025

is a property to states a given feature should not be used for routing connectivity knowledge.

@nickerso that appears to be the intent of noLaterality, assuming there's going to be an update to mapmaker to support it, although a better name is needed -- @napakalas what about unrouted??

@napakalas
Copy link
Contributor Author

@nickerso that appears to be the intent of noLaterality, assuming there's going to be an update to mapmaker to support it, although a better name is needed -- @napakalas what about unrouted??

@dbrnz , I was thinking about that. yes definitely, unroute is a better naming. I'll update it.

@dbrnz
Copy link
Contributor

dbrnz commented Feb 12, 2025

unrouted (an adjective), not unroute (a verb).

@dbrnz dbrnz merged commit 38c5ca6 into AnatomicMaps:curation Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants